-
Notifications
You must be signed in to change notification settings - Fork 757
GenAI Utils Structure #3672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
keith-decker
wants to merge
12
commits into
open-telemetry:main
Choose a base branch
from
splunk:genai-instrumentation-sdk-base
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
GenAI Utils Structure #3672
keith-decker
wants to merge
12
commits into
open-telemetry:main
from
splunk:genai-instrumentation-sdk-base
+279
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-decker
commented
Aug 4, 2025
@pmcollins - Mind taking a look? |
LGTM. @aabmass could you review it? |
keith-decker
commented
Aug 5, 2025
91pavan
reviewed
Aug 6, 2025
pmcollins
reviewed
Aug 6, 2025
pmcollins
reviewed
Aug 7, 2025
instrumentation-genai/opentelemetry-genai-utils/src/opentelemetry/genai/utils/package.py
Outdated
Show resolved
Hide resolved
pmcollins
reviewed
Aug 7, 2025
opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap_gen.py
Outdated
Show resolved
Hide resolved
pmcollins
approved these changes
Aug 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment -- other than that LGTM.
util/opentelemetry-genai-utils/src/opentelemetry/genai/utils/package.py
Outdated
Show resolved
Hide resolved
91pavan
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates the Structure for the GenAI Utils package. The GenAI Utils package will include boilerplate and helpers to standardize instrumentation for Generative AI. Once implementation is complete, this package will provide APIs and decorators to minimize the work needed to instrument genai libraries, while providing standardization for generating both types of otel, "spans and metrics" and "spans, metrics and events"
Here's a link to the design document for the upcoming implementation: https://docs.google.com/document/d/1w9TbtKjuRX_wymS8DRSwPA03_VhrGlyx65hHAdNik1E/edit?tab=t.qneb4vabc1wc#heading=h.kh4j6stirken
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
N/A - No tests in this structure PR
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.