-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Feat/support mcp resources #1042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amri369
wants to merge
48
commits into
openai:main
Choose a base branch
from
amri369:feat/support-mcp-resources
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+395
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Integrate MCP Resources. This allows MCP servers to expose data and content that can be read by clients and used as context for LLM interactions.
Key changes:
MCPServer
:list_resources
,list_resource_templates
andread_resource
_MCPServerWithClientSession
which is parent of classesMCPServerStdio
,MCPServerSse
, andMCPServerStreamableHttp
.Note: This PR does not implement
subscribe_resource
andunsubscribe_resource
methods.Test plan
Unit tests: Added 4 comprehensive tests in tests/mcp/test_resources_server.py covering:
Example verification: Created working example with MCP resources server and client
All tests pass: 453/453 tests passing after adding optional dependencies
Issue number
Partially addresses #544 (resources only)
Checks