enhancement: Add tool_name to ToolContext to support shared tool handlers #1043
+61
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
requested changes
Jul 10, 2025
… tool_context.from_agent_context, Aligned formatting in _run_impl.py
|
Thanks for the thoughtful feedback @seratch! I've pushed an update that addresses it..if any changes are needed further, please lmk! |
seratch
approved these changes
Jul 10, 2025
There was a problem hiding this comment.
Once the added ### Tool context document section is deleted and #1048 gets merged, this looks good to me.
@rm-openai Can you take a quick look and share thoughts if you have any?
Co-authored-by: Kazuhiro Sera <seratch@openai.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
tool_namefield toToolContext, which gets passed into theon_invoke_toolhandler. Helpful for scenarios where we dynamically register multiple tools that all share a single generic handler e.g.in multi-agent setups.As such, by including the name of the tool that was invoked, the handler can now easily branch logic or route requests accordingly.
Resolves #1030
All tests pass. and here is a script to test it out https://gist.github.com/vrtnis/ca354244f7a5ecd9a73c0a2d34cb194b