Skip to content

Realtime: make sure we use the initial model settings #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2025
Merged

Realtime: make sure we use the initial model settings #1198

merged 1 commit into from
Jul 21, 2025

Conversation

rm-openai
Copy link
Collaborator

@rm-openai rm-openai commented Jul 21, 2025 •
edited
Loading

Made a mistake here - we were ignoring the settings passed into the Runner init., and only usig the override settings passed to run()

@rm-openai rm-openai changed the base branch from main to rm/pr1185 July 21, 2025 15:04
@rm-openai rm-openai mentioned this pull request Jul 21, 2025
Merged
@rm-openai rm-openai requested a review from seratch July 21, 2025 15:04
rm-openai added a commit that referenced this pull request Jul 21, 2025
@rm-openai
Realtime: add user agent header (#1185)
3e100f5 
---
[//]: # (BEGIN SAPLING FOOTER)
* #1198
* __->__ #1185
Base automatically changed from rm/pr1185 to main July 21, 2025 15:05
@rm-openai rm-openai mentioned this pull request Jul 21, 2025
Closed
@rm-openai rm-openai merged commit 6cb9639 into main Jul 21, 2025
10 checks passed
@rm-openai rm-openai deleted the rm/pr1198 branch July 21, 2025 16:57
@sibblegp
Copy link

Nice work. Appreciate your listening to all the feedback!

@seratch seratch added documentation Improvements or additions to documentation feature:realtime feature:sessions labels Jul 21, 2025
vcshih pushed a commit to veris-ai/openai-agents-python that referenced this pull request Aug 15, 2025
@rm-openai @vcshih
Realtime: make sure we use the initial model settings (openai#1198)
6061576 
Made a mistake here - we were ignoring the settings passed into the
Runner init., and only usig the override settings passed to run()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakrym-oai pakrym-oai pakrym-oai approved these changes

@seratch seratch Awaiting requested review from seratch

Assignees

@pakrym-oai pakrym-oai

Labels
documentation Improvements or additions to documentation feature:realtime feature:sessions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rm-openai @sibblegp @pakrym-oai @seratch