fix: #1594 support Azure OpenAI Realtime connection using headers #1633
Conversation
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
openai-agents-python/src/agents/realtime/openai_realtime.py
Lines 184 to 192 in 6a6b5ea
[P1] Allow header-auth connections without redundant api_key requirement
The new headers option is documented as allowing callers to supply their own authentication headers (e.g., an Azure api-key) so the default Authorization header is not added. However, connect still raises UserError("API key is required") before any header logic runs, even when headers are provided. A client that sets headers={"api-key": "…"} and omits api_key (which is the typical Azure flow) will still fail fast. The check should only enforce api_key when defaults are used; otherwise the feature added in this commit cannot be used unless callers also supply an unused OpenAI-style key.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
|
good catch; fixed |
This pull request resolves #1594. Azure OpenAI's Realtime WeSocket connection establishment requires a different set of request headers. This pull request enables developers to pass it using custom request headers.
Refer to the following resources for more details: