Read tracing API data lazily #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/agents/tracing/processors.py
Outdated
Comment on lines
75
to
85
| def _lazy_read_api_data_from_env(self): | ||
| if self._lazy_read_complete: | ||
| return | ||
|
|
||
| self._lazy_read_complete = True | ||
| if not self.api_key: | ||
| self.api_key = os.environ.get("OPENAI_API_KEY") | ||
| if not self.organization: | ||
| self.organization = os.environ.get("OPENAI_ORG_ID") | ||
| if not self.project: | ||
| self.project = os.environ.get("OPENAI_PROJECT_ID") |
There was a problem hiding this comment.
consider using built-in functools.cached_property from python 3.8 rather than managing state yourself:
Suggested change
| def _lazy_read_api_data_from_env(self): | |
| if self._lazy_read_complete: | |
| return | |
| self._lazy_read_complete = True | |
| if not self.api_key: | |
| self.api_key = os.environ.get("OPENAI_API_KEY") | |
| if not self.organization: | |
| self.organization = os.environ.get("OPENAI_ORG_ID") | |
| if not self.project: | |
| self.project = os.environ.get("OPENAI_PROJECT_ID") | |
| @cached_property | |
| def api_key(self): | |
| return self._api_key or os.environ.get("OPENAI_API_KEY") | |
| @cached_property | |
| def organization(self): | |
| return self._organization or os.environ.get("OPENAI_ORG_ID") | |
| @cached_property | |
| def project(self): | |
| return self._project or os.environ.get("OPENAI_PROJECT_ID") |
2edd037 to
fe0732e
Compare
stevenheidel
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common complaint is that people load their API keys using dotenv:
This causes issues, because by the time you load your dotenv, the batch processor has already read the API key.
Let's lazy load it, so it's deferred to when the processor actually needs the key.