Add reasoning content - fix on #494 #871
Conversation
|
this looks great - can you please fix lint and i can merge? |
|
Any progress for this PR? |
|
Im waiting on this to be merged :( I opened an issue if someone could help me? Sorry if this is not the place |
…tionaries instead of custom ChoiceDelta objects
|
hi! my bad. I didn't check the pytest version. I will update soon |
|
for better readability, I also modified the tests/test_reasoning to include some functions, but it may fail some lints.. which i might need to work on |
|
@rm-openai Oh I was wondering what the problem is, and found out that my tool is based on pytest, while the actual check was based on ruff (via uv run ruff). This led to automatic unsolvable pull.. Hold up for few minutes. my bad |
…eam_response functions.
dcdd038 to
39963a8
Compare
|
I updated the branch to up-to-date, which now should set the mandatory param "prompt" = None for functions get_response and stream_response. |
my personal update on #494
Key changes:
ResponseReasoningItemto use the correct structure withid,summary, andtype="reasoning"fieldsResponseReasoningSummaryPartAddedEventto includesummary_indexparameter and use a dictionary for thepartparameterResponseReasoningSummaryTextDeltaEventto includesummary_indexparameterResponseReasoningSummaryPartDoneEventto includesummary_indexand use a dictionary forpartSummaryobject is accessed in tests (using.textproperty instead of subscript notation)chatcmpl_converter.pyto use theSummaryclass instead of a dictionary for better handlignFixes #494