Skip to content

release: 1.99.8 #2552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 11, 2025
Merged

release: 1.99.8 #2552

merged 7 commits into from
Aug 11, 2025

Conversation

stainless-app[bot]
Copy link
Contributor

@stainless-app stainless-app bot commented Aug 11, 2025 •
edited
Loading

Automated Release PR

1.99.8 (2025-08-11)

Full Changelog: v1.99.7...v1.99.8

Bug Fixes

  • internal/tests: correct snapshot update comment (2784a7a)
  • types: revert ChatCompletionMessageToolCallUnion breaking change (ba54e03)

Chores

  • internal/tests: add inline snapshot format command (8107db8)
  • internal: fix formatting (f03a03d)
  • tests: add responses output_text test (971347b)

Refactors

  • tests: share snapshot utils (791c567)

This pull request is managed by Stainless's GitHub App.

The semver version number is based on included commit messages. Alternatively, you can manually set the version number in the title of this pull request.

For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request.

🔗 Stainless website
📚 Read the docs
🙋 Reach out for help or questions

@stainless-app stainless-app bot requested a review from a team as a code owner August 11, 2025 15:31
@stainless-app stainless-app bot force-pushed the release-please--branches--main--changes--next branch from e16cbda to 897861c Compare August 11, 2025 20:14
@RobertCraigie RobertCraigie mentioned this pull request Aug 11, 2025
Closed
1 task
@stainless-app stainless-app bot merged commit a02ac0d into main Aug 11, 2025
8 checks passed
@stainless-app stainless-app bot deleted the release-please--branches--main--changes--next branch August 11, 2025 20:18
@stainless-app Stainless App
Copy link
Contributor Author

stainless-app bot commented Aug 11, 2025

🤖 Release is at https://github.com/openai/openai-python/releases/tag/v1.99.8 🌻

@malob malob mentioned this pull request Aug 11, 2025
Merged
13 tasks
@malob
Copy link

malob commented Aug 11, 2025

@RobertCraigie, FYI, looks like ba54e03 does not full resolve the breaking change introduced by the change to ChatCompletionMessageToolCallUnion.

@RobertCraigie
Copy link
Collaborator

@malob what's missing?

@malob
Copy link

malob commented Aug 12, 2025

Here's an example from the instructor package.

instructor> ________________________ test_missing_refusal_attribute ________________________
instructor>
instructor> test_model = <class 'tests.test_function_calls.test_model.<locals>.TestModel'>
instructor>
instructor>     def test_missing_refusal_attribute(test_model: type[OpenAISchema]):
instructor>         message_without_refusal_attribute = ChatCompletionMessage(
instructor>             content="test_content",
instructor>             refusal="test_refusal",
instructor>             role="assistant",
instructor>             tool_calls=[
instructor> >               ChatCompletionMessageToolCall(
instructor>                     id="test_id",
instructor>                     function=Function(
instructor>                         name="TestModel",
instructor>                         arguments='{"data": "test_data", "name": "TestModel"}',
instructor>                     ),
instructor>                     type="function",
instructor>                 )
instructor>             ],
instructor>         )
instructor>
instructor> tests/test_function_calls.py:285:
instructor> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
instructor> /nix/store/v72ywdz0dd2d6sb3knymx9ww8r6pcqba-python3-3.13.5/lib/python3.13/typing.py:1317: in __call__
instructor>     result = self.__origin__(*args, **kwargs)
instructor> /nix/store/v72ywdz0dd2d6sb3knymx9ww8r6pcqba-python3-3.13.5/lib/python3.13/typing.py:1317: in __call__
instructor>     result = self.__origin__(*args, **kwargs)
instructor> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
instructor>
instructor> self = typing.Union, args = ()
instructor> kwds = {'function': Function(arguments='{"data": "test_data", "name": "TestModel"}', name='TestModel'), 'id': 'test_id', 'type': 'function'}
instructor>
instructor>     def __call__(self, *args, **kwds):
instructor> >       raise TypeError(f"Cannot instantiate {self!r}")
instructor> E       TypeError: Cannot instantiate typing.Union
instructor>
instructor> /nix/store/v72ywdz0dd2d6sb3knymx9ww8r6pcqba-python3-3.13.5/lib/python3.13/typing.py:560: TypeError

FWIW, I'm mostly engaging with this as the maintainer of the openai Python package in nixpkgs, so mostly noticing dependent packages that are failing to build, which include instructor and fnllm.

Looks like these packages started having build issues in nixpkgs due to failed tests starting with changes to openai in 1.99.2.

It may totally be the case that the checks these packages are doing are too brittle or something such that this shouldn't be your problem. But figured it might be worth flagging given the "revert" commits (in this version, and at least one other recent release) that are related to changes that caused tests to fail in these dependent packages.

@RobertCraigie
Copy link
Collaborator

ah yup thank you - really sorry for the flakiness recently - we're working on tightening this down to make it much more difficult to ship regressions like this in the future.

the ChatCompletionMessageToolCall one should be fixed in the next release #2555

@malob
Copy link

malob commented Aug 12, 2025

Thanks! I can confirm that the affected dependents are all building in nixpkgs without issue against 1.99.9.

@RobertCraigie
Copy link
Collaborator

Amazing thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lupie Lupie Lupie approved these changes

Assignees
No one assigned
Labels
autorelease: tagged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@malob @RobertCraigie @Lupie