kmeans: number of channels in _centers fixed #10258
Conversation
modules/core/src/kmeans.cpp
Outdated
| @@ -458,7 +458,11 @@ double cv::kmeans( InputArray _data, int K, | |||
| { | |||
| best_compactness = compactness; | |||
| if( _centers.needed() ) | |||
| { | |||
| if(_centers.channels() == dims) | |||
There was a problem hiding this comment.
It looks like the function allow to pass complex configuration of input points since in L239 int dims = (isrow ? 1 : data0.cols)*data0.channels(). IMHO it should be possible for the user to provide the same configuration for the OutputArray _centers
There was a problem hiding this comment.
This makes sense, will be implemented
153cda1 to
fb21538
Compare
fb21538 to
9a912ce
Compare
modules/core/src/kmeans.cpp
Outdated
| centers.copyTo(_centers); | ||
| { | ||
| Mat reshaped = centers; | ||
| if(_centers.rows() == 1 && _centers.channels() == dims) |
There was a problem hiding this comment.
the fix is incorrect. The function behavior should not be dependent on the current shape of the output array. Instead, you should check whether the output array (_centers) has the fixed type (e.g. when _centers is std::vector<someT>) or not.
There was a problem hiding this comment.
Done.
But we need to check actual channels() number (which shouldn't depend on current shape of array).
resolves #10174