Skip to content

Fix issue #6450 #15464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2020
Merged

Fix issue #6450 #15464

merged 2 commits into from
Feb 3, 2020

Conversation

tallestorange
Copy link
Contributor

@tallestorange tallestorange commented Sep 5, 2019 •
edited by alalek
Loading

resolves #6450

Fix issue #6450

I changed a logic of cv::VideoCapture().
Because cv::VideoCapture::get returns wrong value and cv::VideoCapture cannot set value.
Transplanting cv::VideoCapture()'s logic of macOS, this problem can be fixed.

allow_multiple_commits=1

@mshabunin mshabunin mentioned this pull request Sep 25, 2019
Closed
@asmorkalov
Copy link
Contributor

@tallestorange Thanks for you contribution. The patch introduces several build warnings on iOS configuration, could you look at it:

/Volumes/build-storage/build/precommit_ios/3.4/opencv/modules/videoio/src/cap_avfoundation.mm:1055:68: warning: values of type 'OSType' should not be used as format arguments; add an explicit cast to 'unsigned int' instead [-Wformat]
1 warning generated.
/Volumes/build-storage/build/precommit_ios/3.4/opencv/modules/videoio/src/cap_avfoundation.mm:1055:68: warning: values of type 'OSType' should not be used as format arguments; add an explicit cast to 'unsigned int' instead [-Wformat]
1 warning generated.
/Volumes/build-storage/build/precommit_ios/3.4/opencv/modules/videoio/src/cap_avfoundation.mm:1055:68: warning: values of type 'OSType' should not be used as format arguments; add an explicit cast to 'unsigned int' instead [-Wformat]
1 warning generated.

CI link: https://pullrequest.opencv.org/buildbot/builders/precommit_ios/builds/20885/steps/build%20framework/

@VadimLevin
Copy link
Contributor

Hello, @tallestorange. Just gently reminder. Do you have any chance to complete this PR and fix introduced warnings?

@asmorkalov asmorkalov added pr: Discussion Required Hackathon https://opencv.org/opencv-hackathon-starts-next-week/ labels Jan 30, 2020
@asmorkalov asmorkalov requested a review from vpisarev January 31, 2020 11:35
vpisarev
vpisarev approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@vpisarev vpisarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning is fixed; can merge it, I think 👍

opencv-pushbot pushed a commit that referenced this pull request Feb 3, 2020
@alalek
Merge pull request #15464 from tallestorange:3.4
8519db8
@opencv-pushbot opencv-pushbot merged commit 1740225 into opencv:3.4 Feb 3, 2020
@alalek alalek mentioned this pull request Feb 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpisarev vpisarev vpisarev approved these changes

Assignees

@vpisarev vpisarev

Labels
Hackathon https://opencv.org/opencv-hackathon-starts-next-week/ platform: ios/osx
Projects
None yet
Milestone
3.4.10
Development

Successfully merging this pull request may close these issues.
6 participants
@tallestorange @asmorkalov @VadimLevin @vpisarev @opencv-pushbot @alalek