Skip to content

Enable 2-channel arrays in resize tests #16189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2023
Merged

Enable 2-channel arrays in resize tests #16189

merged 1 commit into from
Jan 20, 2023

Conversation

mshabunin
Copy link
Contributor

@mshabunin mshabunin commented Dec 18, 2019 •
edited by alalek
Loading

relates #15257

@mshabunin mshabunin changed the base branch from master to 3.4 December 18, 2019 11:51
@alalek alalek mentioned this pull request Dec 18, 2019
Merged
@terfendail terfendail mentioned this pull request Dec 18, 2019
Merged
@alalek alalek mentioned this pull request Dec 18, 2019
Merged
@asmorkalov asmorkalov added the Hackathon https://opencv.org/opencv-hackathon-starts-next-week/ label Jan 14, 2020
@asenyaev
Copy link
Contributor

asenyaev commented Apr 7, 2021

jenkins cn please retry a build

@asmorkalov
Copy link
Contributor

@mshabunin do you plan to finish the pr?

@mshabunin mshabunin force-pushed the enable-two-channels branch 2 times, most recently from bd1eed8 to 06ed269 Compare October 14, 2022 12:56
mshabunin
mshabunin commented Oct 14, 2022
View reviewed changes
modules/ts/src/ts.cpp
@@ -621,20 +621,27 @@ void TS::set_gtest_status()

void TS::update_context( BaseTest* test, int test_case_idx, bool update_ts_context )
{
CV_UNUSED(update_ts_context);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alalek , do you remember whether the changes in this file are necessary? It seems that some calib3d and color conversion tests fail due to this modification.

Copy link
Member

@alalek alalek Oct 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are used to have reproducible initial RNG seed (independent and different for each test_case_idx of the legacy test system).

RNG seeds are changed by this modification, so some tests are started to fail. This is the question to the testing code and performed checks.

@mshabunin mshabunin mentioned this pull request Nov 15, 2022
Merged
@mshabunin mshabunin force-pushed the enable-two-channels branch 2 times, most recently from c5de027 to 8dbd818 Compare January 18, 2023 16:01
@mshabunin
Copy link
Contributor Author

mshabunin commented Jan 18, 2023 •
edited
Loading

The PR have passed all checks now. Following is the list of changes:

  • (1) enabled 2-channel arrays in imgwarp tests (the main purpose of this PR) - this change caused some tests failure due to changed RNG state, so we...
  • (2) enabled RNG resetting for old-style (e.g. based on ArrayTest) tests to make them more stable
  • (3) increased test threshold in test_convhull.cpp (MinTriangle), test_color.cpp (Lab, Luv), test_homohraphy.cpp (max_diff)
  • (3) partially converted Calib3d_Homography.accuracy to new style (plain GTest) and cv::theRNG()

Maybe there are too many commits? I can squash them into 1, 2 or 3 according to categories above if needed - please let me know.

@alalek
Copy link
Member

alalek commented Jan 18, 2023

@mshabunin Please squash and rebase commits to enable GitHub Actions checks too (GHA fetch workflows from source branch only :\ ).

@mshabunin mshabunin force-pushed the enable-two-channels branch from 8dbd818 to 6a129f0 Compare January 19, 2023 09:45
@mshabunin mshabunin force-pushed the enable-two-channels branch from 9e134d3 to 6902066 Compare January 19, 2023 12:40
@mshabunin
Copy link
Contributor Author

It should be good now - I've rebased and "fixed" one flaky test in video module.

@opencv-pushbot opencv-pushbot merged commit 17e860a into opencv:3.4 Jan 20, 2023
@alalek alalek mentioned this pull request Jan 21, 2023
Merged
@mshabunin mshabunin deleted the enable-two-channels branch January 24, 2023 13:03
@alalek alalek mentioned this pull request Jan 28, 2023
Merged
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alalek alalek alalek approved these changes

@andjelatodorovic andjelatodorovic andjelatodorovic approved these changes

Assignees

@alalek alalek

Labels
bug category: imgproc test
Projects
None yet
Milestone
3.4.20
Development

Successfully merging this pull request may close these issues.
6 participants
@mshabunin @asenyaev @asmorkalov @alalek @andjelatodorovic @opencv-pushbot