Skip to content

Update resize.cpp #16810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update resize.cpp #16810

wants to merge 1 commit into from

Conversation

zexuan
Copy link

@zexuan zexuan commented Mar 14, 2020 •
edited
Loading

lanczosLobes can only be 2 or 3

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@zexuan
Update resize.cpp
27772bf 
lanczosLobes can only be 2 or 3
@asmorkalov
Copy link
Contributor

Could you provide some issue reproducer and reason for the change. The patch breaks existing tests: https://pullrequest.opencv.org/buildbot/builders/precommit_linux64/builds/25282/steps/test_imgproc/logs/stdio

@asmorkalov
Copy link
Contributor

IPP docs: https://software.intel.com/en-us/ippiw-dev-guide-and-reference-class-iwiresizeparams

@asmorkalov
Copy link
Contributor

Math part: https://software.intel.com/en-us/ipp-dev-reference-lanczos-interpolation

@asmorkalov
Copy link
Contributor

@zexuan The issue was discussed with @alalek @vladimir-dudnik @VadimLevin and @asmorkalov on weekly team meeting. The original code works as designed and it looks like lanczosLobes=4 mode is not well documented on IPP side. The documentation issue will be filed to Intel IPP in mean time.

@asmorkalov asmorkalov closed this Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
category: imgproc incomplete pr: Discussion Required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zexuan @asmorkalov