Skip to content

Fixed typo in CV_Error message #20879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2021
Merged

Fixed typo in CV_Error message #20879

merged 1 commit into from
Oct 17, 2021

Conversation

Wehzie
Copy link
Contributor

@Wehzie Wehzie commented Oct 14, 2021

Error was "Input parameters must be a matrices!", but "matrices" is plural and doesn't allow the unspecific article "a".

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@alalek
Copy link
Member

alalek commented Oct 15, 2021

Thank you for contribution!

This patch should go into 3.4 branch first.
We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

Please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@Wehzie @alalek
Fixed typo in CV_Error message
f9e747d 
Error was "Input parameters must be a matrices!", but "matrices" is plural and doesn't allow the unspecific article "a".
@Wehzie
Copy link
Contributor Author

Wehzie commented Oct 17, 2021

Thank you 👍

@opencv-pushbot opencv-pushbot merged commit e6c68ee into opencv:3.4 Oct 17, 2021
@alalek alalek mentioned this pull request Oct 23, 2021
Merged
@alalek alalek mentioned this pull request Dec 30, 2021
Merged
@alalek alalek mentioned this pull request Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels
category: calib3d category: documentation Documentation fix or update
Projects
None yet
Milestone
3.4.17
Development

Successfully merging this pull request may close these issues.
3 participants
@Wehzie @alalek @opencv-pushbot