-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
32bit rgb bmp file should not copy data as rgba #20916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fixed bug, I found that opencv always copy 32 bit bmp data as rgba(4 channels), but rgb data can set as 32 bit pre pixel too, so we need to check BI_RGB, I have added the test file test_32bit_rgb.bmp to opencv_extra repo. |
Thank you for contribution! As a bug fix this patch should go into 3.4 branch first. Please:
Note: no needs to re-open PR, apply changes "inplace". Please rebase related opencv_extra PR too. |
I have pushed my change to 3.4, please check, thank you! |
needs to force push to the branch |
b38343f
to
ce68291
Compare
Thank you for update!
Could you please to put small image to opencv_extra? E.g. 16x16 or 64x64 pixels shuold be enough. |
I pushed an image which is 48x48 pixels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! Thank you 👍
Merge with extra: opencv/opencv_extra#927
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.