Fix problems in tutorial and python sample of dnn_face. #20935
Conversation
|
@crywang Thanks for the contribution! The best solution for code snippets in documentation is substitution from existing sample code. Samples are built by CI and syntax checks happen for documentation too. I propose to use
|
documentation code snippets should go to BTW, Regular samples should be "full featured", e.g, provide useful result. |
|
I believe we can merge this "as is" and improve this later ( /cc @fengyuentau ) |
|
I am confident that the document and sample codes will be improved in the near future according to the suggestions raised by @asmorkalov and @alalek. |
|
@alalek , do you suggest we should move code snippets (face_detect.cpp, face_detect.py, face_match.cpp, face_match.py in samples/dnn) to sameples/cpp/tutorial_code/objdetect? BTW, I think our samples are already "full featured" according to your perspective. Correct me if I misunderstand something. |
| ```cpp | ||
| // Initialize FaceRecognizer with model path (cv::String) | ||
| Ptr<FaceRecognizer> faceRecognizer = FaceRecognizer::create(model_path, ""); | ||
| // Initialize FaceRecognizerSF with model path (cv::String) | ||
| Ptr<FaceRecognizerSF> faceRecognizer = FaceRecognizerSF::create(model_path, ""); |
There was a problem hiding this comment.
This content should be moved to .cpp files (to be checked through compiler run).
Fix problems in tutorial and python sample of dnn_face. * Update dnn_face.markdown * Update face_match.py
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.