Skip to content

(3.4) highgui: drop invalid cvGetWindowImageRect #20980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2021
Merged

(3.4) highgui: drop invalid cvGetWindowImageRect #20980

merged 1 commit into from
Oct 30, 2021

Conversation

alalek
Copy link
Member

@alalek alalek commented Oct 30, 2021

return type is C++ template

relates #10412

force_builders=Custom Win
buildworker:Custom Win=windows-3
test_opencl:Custom Win=ON
build_image:Custom Win=oneapi-2021.4.0-clang

@alalek alalek mentioned this pull request Oct 30, 2021
Closed
@alalek
Copy link
Member Author

alalek commented Oct 30, 2021

ABI is broken anyway.

Removed Symbols  1 
highgui_c.h, libopencv_highgui.so.3.4.16
cvGetWindowImageRect ( char const* name )

Will drop this wrong "C" symbol completely.

@alalek
highgui: drop invalid cvGetWindowImageRect
0ee61d1 
- return type is C++ template
- removal from 'extern "C"' scope broke ABI anyway, so this symbols is removed completelly
@alalek alalek mentioned this pull request Oct 30, 2021
Merged
@alalek
Copy link
Member Author

alalek commented Oct 30, 2021

👍

@opencv-pushbot opencv-pushbot merged commit bce76a7 into opencv:3.4 Oct 30, 2021
@alalek alalek mentioned this pull request Oct 30, 2021
Merged
@alalek alalek mentioned this pull request Dec 30, 2021
Merged
@alalek alalek mentioned this pull request Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alalek alalek

Labels
bug category: build/install category: highgui-gui port/backport done Label for maintainers. Authors of PR can ignore this
Projects
None yet
Milestone
3.4.17
Development

Successfully merging this pull request may close these issues.
2 participants
@alalek @opencv-pushbot