Audio MSMF: added the ability to set sample per second #21145
Conversation
modules/videoio/src/cap_msmf.cpp
Outdated
| if (value != 8000 && value != 11025 && value != 22050 && value != 44100) | ||
| { | ||
| CV_LOG_ERROR(NULL, "VIDEOIO/MSMF: CAP_PROP_AUDIO_SAMPLES_PER_SECOND parameter value is invalid/unsupported: " << value); | ||
| return false; | ||
| } |
There was a problem hiding this comment.
I believe MSMF framework should know better which data rate is supported. There is no limitation on OpenCV side (except may be >= 0 validation check). No need to duplicate MSMF logic in OpenCV code - no way to maintain this approach.
Need to ensure that MSMF should properly return "false" from .open() with unsupported parameter value.
modules/videoio/src/cap_msmf.cpp
Outdated
| if (isOpen) | ||
| { | ||
| if (audioStream != -1) | ||
| checkAudioProperties(); |
There was a problem hiding this comment.
checkAudioProperties();
We should not ignore return value.
Function returns false on errors. Perhaps we should .close capture object in that case.
When is configureAudioOutput() called in this flow?
There was a problem hiding this comment.
In open, first called configureOutput, then inside this function called configureAudioOutput. If I understood the question correctly
There was a problem hiding this comment.
My bad. This note is about setAudioProperties() call above (line 1154)
modules/videoio/src/cap_msmf.cpp
Outdated
| { | ||
| CV_LOG_ERROR(NULL, "VIDEOIO/MSMF: CAP_PROP_AUDIO_SAMPLES_PER_SECOND parameter value is invalid/unsupported: " << audioSamplesPerSecond | ||
| << ". Current value of CAP_PROP_AUDIO_SAMPLES_PER_SECOND: " << actualAudioSamplesPerSecond); | ||
| captureAudioFormat.nSamplesPerSec = actualAudioSamplesPerSecond; |
There was a problem hiding this comment.
captureAudioFormat.nSamplesPerSec = actualAudioSamplesPerSecond;
We should call close() here because we can't satisfy requested parameters.
Audio MSMF: added the ability to set sample per second * Audio MSMF: added the ability to set sample per second * changed the valid sampling rate check * fixed docs * add test * fixed warning * fixed error * fixed error
I changed the CAP_PROP_AUDIO_SAMPLES_PER_SECOND property from (read-only) to (open, read). Acceptable values are 8.0 kHz, 11.025 kHz, 22.05 kHz, and 44.1 kHz. If the value is not set, the behavior is standard.
@alalek