Skip to content

fix Clip, LeakyReLU, LRN, Split defaults #21152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

rogday
Copy link
Member

@rogday rogday commented Nov 29, 2021

A few fixes for #21078, tests are coming to 4.x with #21088

Clip default min and max: https://github.com/onnx/onnx/blob/master/docs/Operators.md#clip
LeakyReLU default alpha: https://github.com/onnx/onnx/blob/master/docs/Operators.md#leakyrelu
LRN default alpha: https://github.com/onnx/onnx/blob/master/docs/Operators.md#lrn
Split default axis: https://github.com/onnx/onnx/blob/master/docs/Operators.md#split

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@opencv-pushbot opencv-pushbot merged commit 0d2857a into opencv:3.4 Nov 29, 2021
@rogday rogday deleted the fix_defaults branch December 2, 2021 17:15
@alalek alalek mentioned this pull request Dec 3, 2021
@alalek alalek mentioned this pull request Dec 30, 2021
@alalek alalek mentioned this pull request Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants