Skip to content

Add acos, acosh, asin, asinh, atan, atanh, cos, cosh, erf, hardswish, sin, sinh, softplus, softsign, tan layers #21176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2021
Merged

Add acos, acosh, asin, asinh, atan, atanh, cos, cosh, erf, hardswish, sin, sinh, softplus, softsign, tan layers #21176

merged 1 commit into from
Dec 17, 2021

Conversation

rogday
Copy link
Member

@rogday rogday commented Dec 2, 2021 •
edited
Loading

Tests are coming to 4.x with #21088

ONNX reference:
Acos, Acosh, Asin, Asinh, Atan, Atanh, Cos, Cosh, Erf, HardSwish, Sin, Sinh, Softplus, Softsign, Tan

Note:
tan test is failing accuracy check under CUDA_FP16 (but values look close) and OCL_FP16

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom,Custom Win,Custom Mac

buildworker:Custom=linux-4,linux-6
Xbuild_image:Custom=ubuntu-cuda:16.04
build_image:Custom=ubuntu-cuda:18.04

Xbuild_image:Custom=ubuntu-openvino-2021.4.2:20.04
Xbuild_image:Custom=ubuntu-openvino-2021.3.0:20.04
Xbuild_image:Custom=ubuntu-openvino-2021.2.0:20.04
Xbuild_image:Custom=ubuntu-openvino-2020.3.0:16.04
build_image:Custom Win=openvino-2021.4.2
Xbuild_image:Custom Win=openvino-2021.3.0-vc16
build_image:Custom Mac=openvino-2021.4.0

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

Xbuildworker:Custom=linux-1
Xtest_opencl:Custom=ON
Xtest_bigdata:Custom=1
Xtest_filter:Custom=*

test_bigdata:Custom Win=1
buildworker:Custom Win=windows-3
test_opencl:Custom Win=ON
test_filter:Custom Win=*

@asmorkalov
Copy link
Contributor

cc @YashasSamaga

@asmorkalov asmorkalov requested a review from sl-sergei December 3, 2021 07:30
YashasSamaga
YashasSamaga reviewed Dec 3, 2021
View reviewed changes
@rogday rogday marked this pull request as draft December 6, 2021 10:58
@rogday rogday marked this pull request as ready for review December 6, 2021 11:14
alalek
alalek approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@opencv-pushbot opencv-pushbot merged commit c39b836 into opencv:4.x Dec 17, 2021
@rogday rogday deleted the eltwise_layers branch December 17, 2021 21:57
@asmorkalov asmorkalov mentioned this pull request Dec 22, 2021
Open
@alalek alalek mentioned this pull request Dec 30, 2021
Merged
@alalek alalek mentioned this pull request Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YashasSamaga YashasSamaga YashasSamaga left review comments

@alalek alalek alalek approved these changes

@sl-sergei sl-sergei Awaiting requested review from sl-sergei

Assignees

@alalek alalek

Labels
category: dnn feature
Projects
None yet
Milestone
4.5.5
Development

Successfully merging this pull request may close these issues.
6 participants
@rogday @asmorkalov @alalek @YashasSamaga @opencv-pushbot @sl-sergei