Added CV_PROP_RW macro to keypoints #21180
Conversation
As outlined in the feature request in the issue #21171 : the keypoints field has been made parsable by the bindings.
|
Thank you for contribution! Please add simple Python test to ensure that this code works as expected: Prefer to test binding itself, not an accuracy of C++ code. |
|
@alalek Please check if the added test is correct and I am happy to follow up. |
|
Thank you for update! There is a whitespace issue in this PR: http://pullrequest.opencv.org/buildbot/builders/precommit_docs/builds/33206 (line of spaces) But commits for this PR broke GitHub review page and we don't see malicious changes here.
We don't need this commit at all.
It is better to avoid using source branches with the names from upstream for creation of PRs. |
Added test to check if the CV_PROP_RW macro added in the previous commit makes keypoints public and accessible through the python API.
|
I have rolled back the merge and removed the whitespace new line. Please check if it works now. Thank you. |
Added CV_PROP_RW macro to keypoints * Added CV_PROP_RW macro to keypoints As outlined in the feature request in the issue opencv#21171 : the keypoints field has been made parsable by the bindings. * Added test for keypoints Added test to check if the CV_PROP_RW macro added in the previous commit makes keypoints public and accessible through the python API.
As outlined in the feature request in the issue #21171 : the keypoints field has been made parsable by the bindings.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.