Skip to content

Add ArgMax and ArgMin layers #21208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Conversation

rogday
Copy link
Member

@rogday rogday commented Dec 6, 2021

Merge with extra: opencv/opencv_extra#941

Note: ArgMax/ArgMin layers should output int64 tensor per standard, but DNN module uses floats everywhere.

opencv_extra=argminmax_dnn

resolves #10286
relates #20733

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@rogday rogday marked this pull request as draft December 6, 2021 14:44
@rogday rogday marked this pull request as ready for review December 6, 2021 16:35
@sl-sergei
Copy link
Contributor

sl-sergei commented Dec 7, 2021

Do we plan to add this only for 4.x+ versions?

@opencv-pushbot opencv-pushbot merged commit 41d108e into opencv:4.x Dec 7, 2021
@rogday rogday deleted the argminmax_dnn branch December 10, 2021 09:02
@alalek alalek mentioned this pull request Dec 30, 2021
@alalek alalek mentioned this pull request Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for new type of reduce(): REDUCE_MAX_IND
4 participants