Skip to content

clip13 #27570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

clip13 #27570

wants to merge 10 commits into from

Conversation

nklskyoy
Copy link

clip13 is produced by pytorch when exporting paligemma to onnx.
https://onnx.ai/onnx/operators/onnx__Clip.html

Existing clip can't handle cases where min max are non-const.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov requested a review from vpisarev July 21, 2025 10:26
@asmorkalov asmorkalov added GSoC category: dnn (onnx) ONNX suport issues in DNN module labels Jul 21, 2025
@asmorkalov
Copy link
Contributor

The PR breaks existing NanoTrack tracker in video (dnn based):

[ RUN      ] NanoTrack.accuracy_NanoTrack_V1
unknown file: error: SEH exception with code 0xc0000005 thrown in the test body.
[  FAILED  ] NanoTrack.accuracy_NanoTrack_V1 (16 ms)

dkurt
dkurt reviewed Jul 24, 2025
View reviewed changes
@asmorkalov
Copy link
Contributor

@nklskyoy friendly reminder

@nklskyoy
Copy link
Author

The PR breaks existing NanoTrack tracker in video (dnn based):

[ RUN      ] NanoTrack.accuracy_NanoTrack_V1
unknown file: error: SEH exception with code 0xc0000005 thrown in the test body.
[  FAILED  ] NanoTrack.accuracy_NanoTrack_V1 (16 ms)

@asmorkalov not sure how to reproduce, since there is no data for the test locally.

asmorkalov
asmorkalov reviewed Jul 30, 2025
View reviewed changes
dkurt
dkurt reviewed Aug 1, 2025
View reviewed changes
dkurt
dkurt reviewed Aug 4, 2025
View reviewed changes
@asmorkalov asmorkalov mentioned this pull request Aug 4, 2025
Merged
6 tasks
@asmorkalov
Copy link
Contributor

Closed as #27624 has broader types support.

@asmorkalov asmorkalov closed this Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmorkalov asmorkalov asmorkalov left review comments

@dkurt dkurt dkurt approved these changes

@vpisarev vpisarev Awaiting requested review from vpisarev

Assignees
No one assigned
Labels
category: dnn (onnx) ONNX suport issues in DNN module GSoC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nklskyoy @asmorkalov @dkurt