Support Symbol.dispose for using keyword in OpenCV.js (#26157) #27613
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’ve implemented Symbol.dispose support for OpenCV.js classes as described in #26157. All relevant JS-related CI suites have passed. I did notice a failure in the Thanks for reviewing—happy to make any adjustments needed! |
asmorkalov
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new
Symbol.disposeproposal, allowing OpenCV.js objects such ascv.Matandcv.UMatto be used with the upcomingusingkeyword in JavaScript (TC39 proposal) and TypeScript 5.2+.[Symbol.dispose]as an alias to.delete()for resource-managed OpenCV.js classesSymbol.disposeCloses #26157.
Motivation:
Manual
.delete()calls can be error-prone and verbose. Supporting the newusingkeyword will improve resource safety and developer ergonomics per the TC39 proposal and TypeScript documentation.Please let me know if there’s any other class to include, or if you’d like further tests or documentation.