Add more information to the error code. #8359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alalek
reviewed
Mar 11, 2017
| BadModelOrChSeq= -14, //!< | ||
| BadNumChannels= -15, //!< | ||
| BadNumChannels= -15, //!< bad number of channels |
There was a problem hiding this comment.
Probably it is "not wrong", neither "invalid" or "bad" - current value is usually "not supported"/"unsupported" by current implementation.
There was a problem hiding this comment.
I copied the information from https://github.com/opencv/opencv/blob/master/modules/core/src/system.cpp#L764
In this case, does the function cvErrorStr also need to be updated, returning "supported/unsupported" ?
|
@csukuangfj, since you've started it, can you please also add comments to all other error codes? |
|
@vpisarev I have added comments to every enums that are used in the source code. Some of the enums are defined but never used and I do not understand its exact meaning, so they are left |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pullrequest changes