Fix some but not all undefined names in scripts/__init__.py #589
Conversation
| @@ -1,3 +1,6 @@ | |||
| import os | |||
| import sys | |||
There was a problem hiding this comment.
scripts/init.py
AFAIK, it is not a standalone script. It is used through eval()
There was a problem hiding this comment.
eval() is evil ;-) but if these imports have already been done then these lines become no-ops but if the imports have not been done then these lines will prevent crashes.
There was a problem hiding this comment.
@cclauss, you mean it prevents crashes in a linting job?
There was a problem hiding this comment.
Crashes in any situation where os and sys have not already been imported by some other file.
As it says in The Zen of Python", explicit is better than implicit.
|
I'm going to merge |
Add missing imports that were removed in #563