Skip to content

Changed labeles for macOS ARM64 and Linux ARM64 builds #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 4, 2022
Merged

Changed labeles for macOS ARM64 and Linux ARM64 builds #681

merged 5 commits into from
Jul 4, 2022

Conversation

asenyaev
Copy link
Contributor

No description provided.

@asenyaev asenyaev changed the title Changed labeles for macOS ARM64 and Linux ARM64 builds Draft: Changed labeles for macOS ARM64 and Linux ARM64 builds Jun 23, 2022
@asenyaev asenyaev requested a review from fengyuentau June 23, 2022 17:02
@fengyuentau
Copy link
Member

It seems a lot of workflows are added to the machines on my side. Will it be too heavy for them?

@asenyaev
Copy link
Contributor Author

It seems a lot of workflows are added to the machines on my side. Will it be too heavy for them?

No, there are only 4 builds for each machine and other workflows are OpenCV python tests. In addition, this repository runs workflows quite rare.

@asenyaev asenyaev requested a review from asmorkalov June 27, 2022 10:32
@asenyaev asenyaev changed the title Draft: Changed labeles for macOS ARM64 and Linux ARM64 builds Changed labeles for macOS ARM64 and Linux ARM64 builds Jun 27, 2022
@asenyaev
Copy link
Contributor Author

asenyaev commented Jun 27, 2022

The last one issue - the network connection of Linux ARM64 machine.

Copy link
Member

@fengyuentau fengyuentau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the cleanup steps use asenyaev/cleanup-action@v1, some others use find . -mindepth 1 -delete, and the others use rm -rf ./*. If your asenyaev/cleanup-action@v1 can work across platforms, then just use your cleanup action for simplicity and unity.

BTW, Zihao is working on the network issue on the Linux ARM64 machine. It seems the problem is somehow related to the IPV6 routing on the machine.

Others look good to me👍

@asenyaev
Copy link
Contributor Author

@fengyuentau, thank you for the update!

My custom action works only with docker, because it was created using dockerfile and entrypoint bash script. I'm going to rebuild docker images which are used for build jobs using the non-root user to avoid permission issues when need to delete also hidden files (.git).

@asenyaev asenyaev merged commit 4638ce5 into opencv:master Jul 4, 2022
@asenyaev asenyaev deleted the asen/change_labels branch July 4, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants