Skip to content

matlab: Use OpenCV_SOURCE_DIR instead of CMAKE_SOURCE_DIR to find the modules root #3313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Qubiz
Copy link
Contributor

@Qubiz Qubiz commented Jul 28, 2022

This fixes #3312

Previously the OpenCV modules was found using CMAKE_SOURCE_DIR which always points to the top level CMake directory.

Using OpenCV_SOURCE_DIR allows for a more robust way of getting the path to the OpenCV modules root and ensures that the HDR_PARSER_PATH is correctly set.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Qubiz added 2 commits July 28, 2022 10:00
This sets the `HDR_PARSER_PATH` variable using `OpenCV_SOURCE_DIR` instead of using `CMAKE_SOURCE_DIR`.
This allows for more flexibility in how the user's project can be structured.
@alalek alalek merged commit 087a100 into opencv:4.x Aug 26, 2022
@alalek alalek mentioned this pull request Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error generating Matlab code - ModuleNotFoundError: No module named 'hdr_parser'
2 participants