feature(pu): add rope that use the true timestep index as pos_index #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 11, 2025 17:34
…nd reanalyze_phase
PaParaZz1
requested changes
Mar 27, 2025
| return obs_act_embeddings + self.pos_emb(prev_steps + torch.arange(num_steps, device=self.device)), num_steps | ||
| return_result = obs_act_embeddings | ||
| if not self.config.rotary_emb: | ||
| return_result += self.pos_emb(prev_steps + torch.arange(num_steps, device=self.device)) |
There was a problem hiding this comment.
you don't need to add this if branch here
There was a problem hiding this comment.
The polishing of pos_emb will be addressed in a future PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add rope that use the true timestep index as pos_index in unizero's transformer
Current performance on Pong:
Current performance on cartpole-swingup:
