⚠️ No Changeset found

Latest commit: 9b06bf6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

The latest updates on your projects. Learn more about Vercel for Git ↗︎

@sladg is there anything special I need to do to get the autoformat to work? I have eslint and prettier plugin installed in my VSCode, but when I save a file, it doesn't add the commas.
The eslint is picking up the rules but it's not applying the changes on save.

@khuezy disable prettier plugin. Only eslint is needed as prettier does not have configuration file in workspace so it's fighting with eslint most likely.

I think I have some weird VSCode settings in my global VSCode settings somewhere in my /Library/Application Support/Code/User. It might be better to create a .vscode/settings.json file to force the project to adhere to open-next's VSCode settings.

My VSCode broke... so I can't really test this PR smh...

I was using typescript 5.2.2 and the eslint lib didn't support it yet. The fix got deployed ~30m ago and everything is working after I reinstall to pick up new packages. See: typescript-eslint/typescript-eslint#7155 (comment)

We should upgrade to latest TS too

Do you mind adding .vscode/settings.json:

{
  "editor.codeActionsOnSave": {
    "source.fixAll.eslint": true
  },
}

That will autoformat to the style on save.

I also had to make some changes to server-adapter.ts. Let me know if you want me to push the changes up or not.