Skip to content

fix(cloudflare): PPR in wrangler dev #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2025
Merged

fix(cloudflare): PPR in wrangler dev #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/lucky-actors-flash.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"@opennextjs/aws": patch
---

fix(cloudflare): PPR in wrangler dev

PPR works fine when deployed but not in dev because of bug in miniflare.
Adding a workaround until the bug is fixed upstream.
6 changes: 6 additions & 0 deletions packages/open-next/src/overrides/wrappers/cloudflare-node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,12 @@ const handler: WrapperHandler<InternalEvent, InternalResult> =
responseHeaders.append("Set-Cookie", cookie);
}

// TODO(vicb): this is a workaround to make PPR work with `wrangler dev`
// See https://github.com/cloudflare/workers-sdk/issues/8004
if (url.hostname === "localhost") {
responseHeaders.set("Content-Encoding", "identity");
}

const { readable, writable } = new TransformStream({
transform(chunk, controller) {
controller.enqueue(Uint8Array.from(chunk.chunk ?? chunk));
Expand Down