Skip to content

fix(cloudflare): enable trailiing slash redirect #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2025
Merged

fix(cloudflare): enable trailiing slash redirect #722

merged 2 commits into from
Feb 3, 2025

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Feb 3, 2025 •
edited
Loading

event.url is a valid URL within cloudflare vs a path otherwise

Thanks @conico974 for the idea on how to fix.

Note: I'm leaving #719 opened as we probably need to unify what event.url is

@vicb
fix(cloudflare): enable trailiing slash redirect
c64941d 
event.url is a valid URL within cloudflare vs a path otherwise
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 269cbac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 23.96% 1922 / 8020
🔵 Statements 23.96% 1922 / 8020
🔵 Functions 51.15% 111 / 217
🔵 Branches 71.23% 483 / 678
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/core/routing/matcher.ts 77.68% 68.75% 91.66% 77.68% 36-38, 47-51, 56-58, 61, 100, 102, 105, 108, 118-119, 161-163, 276-278, 280-293, 312-313, 375-414
Generated in workflow #923 for commit 269cbac by the Vitest Coverage Report Action

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 3, 2025 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@722

commit: 269cbac

@vicb vicb requested a review from conico974 February 3, 2025 10:15
conico974
conico974 approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a little comment

@vicb @conico974
Update packages/open-next/src/core/routing/matcher.ts
269cbac 
Co-authored-by: conico974 <nicodorseuil@yahoo.fr>
@vicb
Copy link
Contributor Author

vicb commented Feb 3, 2025

Thanks @conico974

@vicb vicb merged commit dd9face into main Feb 3, 2025
3 checks passed
@vicb vicb deleted the cf/trailing-slash branch February 3, 2025 10:25
@github-actions github-actions bot mentioned this pull request Feb 3, 2025
Merged
@vicb vicb mentioned this pull request Feb 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conico974 conico974 conico974 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vicb @conico974