Skip to content

refactor: lastModified moved to ALS #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 12, 2025
Merged

refactor: lastModified moved to ALS #740

merged 2 commits into from
Feb 12, 2025

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Feb 12, 2025

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 1c93a83

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Minor
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 12, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 24.24% 1949 / 8039
🔵 Statements 24.24% 1949 / 8039
🔵 Functions 51.61% 112 / 217
🔵 Branches 71.61% 487 / 680
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/adapters/cache.ts 86.14% 83.16% 100% 86.14% 93-94, 152-154, 157-165, 219-230, 252-253, 382-391, 426-434, 468-469
packages/open-next/src/core/createMainHandler.ts 0% 0% 0% 0% 1-57
packages/open-next/src/core/requestHandler.ts 0% 0% 0% 0% 1-260
packages/open-next/src/core/routing/util.ts 88.49% 88.76% 94.73% 88.49% 208-209, 279-281, 359-382
packages/open-next/src/types/global.ts 0% 0% 0% 0%
Generated in workflow #969 for commit 1c93a83 by the Vitest Coverage Report Action

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 12, 2025 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@740

commit: 1c93a83

@vicb vicb requested a review from conico974 February 12, 2025 09:19
conico974
conico974 approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@vicb @conico974
Update packages/open-next/src/types/global.ts
1c93a83 
Co-authored-by: conico974 <nicodorseuil@yahoo.fr>
@vicb
Copy link
Contributor Author

vicb commented Feb 12, 2025

Thanks for the review Nico!

@vicb vicb merged commit 6ff03ec into main Feb 12, 2025
3 checks passed
@vicb vicb deleted the vb-branch-1 branch February 12, 2025 09:46
This was referenced Feb 12, 2025
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conico974 conico974 conico974 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vicb @conico974