Skip to content

fix localeDetection false #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 1, 2025
Merged

fix localeDetection false #761

merged 5 commits into from
Mar 1, 2025

Conversation

conico974
Copy link
Contributor

@conico974 conico974 commented Feb 28, 2025 •
edited
Loading

With localeDetection:false we should still detect the locale for domain based thing.

TODO

  • Add some test
  • Add some explanation
  • Verify that it's the expected behaviour

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 28, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: d1d8532

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 28, 2025 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@761

commit: d1d8532

@nicholas-c
Copy link

Seems to be working as expected with the following next.config.ts i18n config;

  i18n: {
    locales: ["fr", "en", "es"],
    defaultLocale: "en",
    localeDetection: false,
    domains: [
      {
        domain: "next-15-en.nich-carter-qza3ng.gymshark-sandbox.tools",
        defaultLocale: "en",
        locales: ["fr"],
      },
      {
        domain: "next-15-es.nich-carter-qza3ng.gymshark-sandbox.tools",
        defaultLocale: "es",
      },
    ],
  },

https://next-15-en.nich-carter-qza3ng.gymshark-sandbox.tools/ <- Returns en
https://next-15-en.nich-carter-qza3ng.gymshark-sandbox.tools/fr <- Returns fr
https://next-15-es.nich-carter-qza3ng.gymshark-sandbox.tools/ <- Returns es

vicb
vicb reviewed Feb 28, 2025
View reviewed changes
@conico974 conico974 marked this pull request as ready for review March 1, 2025 09:02
vicb
vicb reviewed Mar 1, 2025
View reviewed changes
@conico974 conico974 merged commit 7b4ea5c into opennextjs:main Mar 1, 2025
3 checks passed
@github-actions github-actions bot mentioned this pull request Mar 1, 2025
Merged
@conico974 conico974 mentioned this pull request Mar 1, 2025
Closed
@conico974 conico974 deleted the fix/i18n-locale-detect-false branch March 14, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicb vicb vicb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conico974 @nicholas-c @vicb