Skip to content

fix: add cookies in express-dev wrapper #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 14, 2025

Conversation

sommeeeer
Copy link
Contributor

we didn't set-cookie in express-dev wrapper. should we call:

res.flushHeaders();
res.uncork();

aswell? like in the node wrapper?

Copy link

changeset-bot bot commented Mar 13, 2025

🦋 Changeset detected

Latest commit: e42a1b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Mar 13, 2025

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@776

commit: e42a1b8

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just add res.flushHeaders()

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@conico974 conico974 merged commit 9720783 into opennextjs:main Mar 14, 2025
3 checks passed
@github-actions github-actions bot mentioned this pull request Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants