Skip to content

Fix: fetch cache set missing wait until #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 20, 2025
Merged

Fix: fetch cache set missing wait until #782

merged 5 commits into from
Mar 20, 2025

Conversation

conico974
Copy link
Contributor

@conico974 conico974 commented Mar 18, 2025 •
edited
Loading

Port of this patch to aws https://github.com/opennextjs/opennextjs-cloudflare/blob/main/packages/cloudflare/src/cli/build/patches/plugins/fetch-cache-wait-until.ts

Can be removed once this get merged : vercel/next.js#75971

Close #736

This PR depends on #781. Should not be merged before it

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: c6daa79

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@conico974 conico974 mentioned this pull request Mar 18, 2025
Merged
@conico974 conico974 force-pushed the fix/fetch-cache-set-missing-waitUntil branch 2 times, most recently from 7ad59c5 to 1ecb990 Compare March 19, 2025 16:15
vicb
vicb reviewed Mar 19, 2025
View reviewed changes
Base automatically changed from feat/code-patching to main March 20, 2025 09:01
@conico974 conico974 force-pushed the fix/fetch-cache-set-missing-waitUntil branch from 514bece to 788ea25 Compare March 20, 2025 09:05
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Mar 20, 2025 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@782

commit: c6daa79

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 20, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 25.74% 2293 / 8905
🔵 Statements 25.74% 2293 / 8905
🔵 Functions 52.71% 126 / 239
🔵 Branches 73.09% 584 / 799
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/build/createServerBundle.ts 0% 0% 0% 0% 1-343
packages/open-next/src/build/patch/patchFetchCacheWaitUntil.ts 100% 100% 100% 100%
Generated in workflow #1078 for commit c6daa79 by the Vitest Coverage Report Action

@conico974 conico974 merged commit a6da6ac into main Mar 20, 2025
3 checks passed
@conico974 conico974 deleted the fix/fetch-cache-set-missing-waitUntil branch March 20, 2025 10:25
@github-actions github-actions bot mentioned this pull request Mar 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicb vicb vicb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

await fetch cache set dangling promise
2 participants
@conico974 @vicb