Skip to content

refactor compareSemver #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

refactor compareSemver #787

merged 1 commit into from
Mar 20, 2025

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Mar 20, 2025

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: c7969e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Mar 20, 2025 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@787

commit: c7969e8

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 20, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 25.93% 2319 / 8940
🔵 Statements 25.93% 2319 / 8940
🔵 Functions 52.71% 126 / 239
🔵 Branches 73.25% 589 / 804
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/build/compileCache.ts 0% 0% 0% 0% 1-48
packages/open-next/src/build/createImageOptimizationBundle.ts 0% 0% 0% 0% 1-124
packages/open-next/src/build/createServerBundle.ts 0% 0% 0% 0% 1-349
packages/open-next/src/build/helper.ts 19.24% 100% 5% 19.24% 21-101, 104-185, 206-224, 235-241, 252-261, 264-270, 273-274, 278-289, 353-365, 368-382, 388-398, 401-402, 405-406, 417-436, 439-440
packages/open-next/src/build/patch/codePatcher.ts 54.31% 93.54% 66.66% 54.31% 55-56, 64-65, 127-184
Generated in workflow #1080 for commit c7969e8 by the Vitest Coverage Report Action

@vicb vicb requested a review from conico974 March 20, 2025 10:28
conico974
conico974 approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks.
I guess we could update the generic patch as well to support different operator if we need to later (not that important for now i guess)

@vicb
Copy link
Contributor Author

vicb commented Mar 20, 2025

I guess we could update the generic patch as well to support different operator if we need to later (not that important for now i guess)

I wanted to do this change for a while but yeah updating the generic patch is what trigger that PR. It would be nice to be able to express i.e. "<15" for patch only required for 14.

Thanks for the review!

@vicb vicb merged commit 73bffc0 into main Mar 20, 2025
3 checks passed
@vicb vicb deleted the vicb/semver branch March 20, 2025 10:50
@github-actions github-actions bot mentioned this pull request Mar 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conico974 conico974 conico974 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vicb @conico974