fix: merge request headers in middleware in app-router example #799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
commit: |
This reverts commit eb7d02f.
vicb
added a commit
to opennextjs/opennextjs-cloudflare
that referenced
this pull request
Apr 7, 2025
vicb
added a commit
to opennextjs/opennextjs-cloudflare
that referenced
this pull request
Apr 7, 2025
vicb
added a commit
to opennextjs/opennextjs-cloudflare
that referenced
this pull request
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing
pnpm build && pnpm startinapp-router. You will get an error when trying to run the e2e test locally for/methods/post/formdata:⨯ TypeError: Content-Type was not one of "multipart/form-data" or "application/x-www-form-urlencoded".The reason is this line:
opennextjs-aws/examples/app-router/middleware.ts
Line 31 in fbe09ae
I guess we need to pass in the request headers already coming in. Reason it works once deployed is because OpenNext doesn't remove them like
next start.I also removed an unused variable in
/src/core/routing/middleware.ts