Skip to content

[V2] backport vulnerability fix #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2025
Merged

[V2] backport vulnerability fix #811

merged 1 commit into from
Apr 2, 2025

Conversation

conico974
Copy link
Contributor

This is a backport of #810 to OpenNext V2

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 2, 2025

⚠️ No Changeset found

Latest commit: 621c095

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@conico974 conico974 requested review from vicb and khuezy April 2, 2025 18:09
vicb
vicb reviewed Apr 2, 2025
View reviewed changes
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How has the change been validated?
Should there be a test?

@conico974
Copy link
Contributor Author

@vicb I'm doing some manual test right now, there wasn't any unit test in V2 and e2e is not possible anymore.
It's the exact same change as in V3, i'll update here once i've finished with my manual test.

khuezy
khuezy reviewed Apr 2, 2025
View reviewed changes
Copy link
Contributor

@khuezy khuezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would there be any way for a user to obtain the prerender manifest and thus get the preview id?

@conico974
Copy link
Contributor Author

No unless they have access to the build or that the prerender manifest has been leaked, but in those cases there is way more issues than just that

@khuezy
Copy link
Contributor

khuezy commented Apr 2, 2025

Just want to triple check that the manifest file doesn't somehow end up in the public folder, eg. Bots will scan for .env files to exploit sites.

khuezy
khuezy approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@khuezy khuezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending your manual tests.

@conico974
Copy link
Contributor Author

Ok it works (i forgot how painful it was to test v2).
Gonna merge this, i hope that the prerelease action still works 🤞

@conico974 conico974 merged commit 4bdeac6 into opennextjs:V2 Apr 2, 2025
@conico974
Copy link
Contributor Author

And it does not work anymore, this might be a long night...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicb vicb vicb left review comments

@khuezy khuezy khuezy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conico974 @khuezy @vicb