add aws-lambda-compressed #819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e1a54cc The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
conico974
reviewed
Apr 8, 2025
packages/open-next/src/overrides/wrappers/aws-lambda-compressed.ts
Outdated
Show resolved
Hide resolved
packages/open-next/src/overrides/wrappers/aws-lambda-compressed.ts
Outdated
Show resolved
Hide resolved
packages/open-next/src/overrides/wrappers/aws-lambda-compressed.ts
Outdated
Show resolved
Hide resolved
conico974
reviewed
Apr 9, 2025
packages/open-next/src/overrides/wrappers/aws-lambda-compressed.ts
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #475
For some apps you might get a
413when your response body is too large. This is a limitation in Lambda. In you AWS console you will get this error message:[ERROR] [xxxxxxxxx] LAMBDA_RUNTIME Failed to post handler success response. Http response code: 413.The default limit in Lambdas is
6mbfor invocation payloads (synchronous request/response). You can read more about its limitations hereThis PR introduces a new wrapper called
aws-lambda-compressedthat will compress the response body by default if the client sends a request with a supported encoding in theAccept-Encodingheader. Compression will be applied in the following priority order:br(Brotli) →gzip→deflate. If none of these is found, we just return the body as is.After some testing on various bodies of reasonable size (8mb+). I found out that the Lambda will timeout after 10s if we use the default
BROTLI_PARAM_QUALITYwhich is11. Its also the highest. Therefore defaulting it to6is probably wise, as a compromise.An environment variable
BROTLI_QUALITYmakes this configurable.