Skip to content

fix use cache flaky test #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

fix use cache flaky test #849

merged 1 commit into from
May 2, 2025
+24 −8

Conversation

conico974
Copy link
Contributor

Because both the revalidateTag and the ssr test could run at the same time, it could cause the ssr test to fail because revalidateTag would have been called by the other test

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 2, 2025

⚠️ No Changeset found

Latest commit: ba7aa9e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

khuezy
khuezy approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor

@khuezy khuezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Slightly off topic: use cache defaults to 15 minutes but I don't think we'll ever hit the scenario where the github action builds the app to the e2e test is > 15minutes, which may cause some flakiness in the tests. But if that ever does happen in the future, that could explain why.

@conico974
Copy link
Contributor Author

Thanks

Slightly off topic: use cache defaults to 15 minutes but I don't think we'll ever hit the scenario where the github action builds the app to the e2e test is > 15minutes, which may cause some flakiness in the tests. But if that ever does happen in the future, that could explain why.

It's even less likely that what you think. use cache right now does not produce build time cache, so for it to be an issue, it would need to be 15 minutes between the first and last request to the same route. And worst case scenario, we just add unstable_cachelife

@conico974 conico974 merged commit c212ed0 into opennextjs:main May 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khuezy khuezy khuezy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conico974 @khuezy