refactor: use the traced file copy from OpenNext #282
Conversation
🦋 Changeset detectedLatest commit: 19f4c2b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
|
Thanks for the review @james-elicx, I'll wait for @dario-piotrowicz to review before I merge this. |
Oops, I merged @james-elicx PR into this one (I forgot it was based on this branch). @dario-piotrowicz you can review the first commit only, thanks! |
There was a problem hiding this comment.
Looks very promising! 😄 🥳
I'm halfway through my review, just leaving a partial review 🙂
Nit: I didn't comment on them since there are quite a few, but you're introducing a bunch of joins that are inconsistent with your convention
packages/cloudflare/src/cli/build/patches/investigated/copy-package-cli-files.ts
Outdated
Show resolved
Hide resolved
packages/cloudflare/src/cli/build/patches/investigated/patch-require.ts
Outdated
Show resolved
Hide resolved
cf08a5c to
91625b2
Compare
|
@dario-piotrowicz I integrated your first batch of feedback, thanks! |
packages/cloudflare/src/cli/build/patches/to-investigate/wrangler-deps.ts
Outdated
Show resolved
Hide resolved
packages/cloudflare/src/cli/build/patches/to-investigate/patch-find-dir.ts
Outdated
Show resolved
Hide resolved
packages/cloudflare/src/cli/build/patches/to-investigate/inline-next-require.ts
Show resolved
Hide resolved
Co-authored-by: Dario Piotrowicz <dario@cloudflare.com>
|
Thanks for the reviews @james-elicx and @dario-piotrowicz ! |
fixes #251
relates to #14
Before this PR, the Next compiled output was copied to
.open-next/.nextand some files were used/patched from there.This PR makes sure we always use the files from
.open-next/.server-functions/<fnName>instead.This allows to simplify a lot of the config object that was used before.