Skip to content

Dump ESBuild metadata to handler.mjs.meta.json #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Dump ESBuild metadata to handler.mjs.meta.json #295

merged 2 commits into from
Jan 29, 2025

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jan 29, 2025

@opennextjs/aws@715 generates meta files. This will help us investigate #14

Copy link

changeset-bot bot commented Jan 29, 2025

🦋 Changeset detected

Latest commit: da4178f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vicb vicb requested review from james-elicx and dario-piotrowicz and removed request for james-elicx January 29, 2025 07:07
Copy link

pkg-pr-new bot commented Jan 29, 2025

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@295

commit: da4178f

@vicb vicb changed the title bump @opennextjs/aws Dump ESBuild metadata to handler.mjs.meta.json Jan 29, 2025
@vicb
Copy link
Contributor Author

vicb commented Jan 29, 2025

Thanks for the review @james-elicx

The first commit was about creating meta files for aws bundles.

I added a second commit to generate the meta file for the cloudflare server bundle.

Would you mind doing a quick review?

Copy link
Collaborator

@james-elicx james-elicx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. we had a similar sort of file in next-on-pages which mapped out how all the different split up parts in the bundle related to each other. turned out to be super handy for debugging some peoples issues.

@vicb
Copy link
Contributor Author

vicb commented Jan 29, 2025

Thanks!

@vicb vicb merged commit 1b3a972 into main Jan 29, 2025
7 checks passed
@vicb vicb deleted the meta-file branch January 29, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants