Skip to content

fix external rewrites to Cloudflare hosted resources not working #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

dario-piotrowicz
Copy link
Contributor

@dario-piotrowicz dario-piotrowicz commented Feb 4, 2025

rewrites to external resources hosted on Cloudflare don't currently work, this PR addresses that by bumping the aws dependency

For more context see: opennextjs/opennextjs-aws#724

Copy link

changeset-bot bot commented Feb 4, 2025

🦋 Changeset detected

Latest commit: 7304ab9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Feb 4, 2025

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@334

commit: 7304ab9

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the aws package so that we get the test result?

…aws@724`

this bump fixes rewrites to external urls not working when the external urls
point to resources hosted on the Cloudflare network
@dario-piotrowicz dario-piotrowicz force-pushed the dario/revert-external-rewrite-url-change branch from bb1a66d to 7304ab9 Compare February 4, 2025 13:54
@dario-piotrowicz dario-piotrowicz changed the title revert destination change in pages-router e2e rewrite fix external rewrites to Cloudflare hosted resources not working Feb 4, 2025
@dario-piotrowicz dario-piotrowicz requested a review from vicb February 4, 2025 13:56
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review February 4, 2025 13:56
@dario-piotrowicz dario-piotrowicz merged commit 1ccff65 into main Feb 4, 2025
7 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/revert-external-rewrite-url-change branch February 4, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants