Skip to content

Fix R2 bucket population #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2025
Merged

Fix R2 bucket population #536

merged 2 commits into from
Apr 7, 2025

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Apr 7, 2025

Fixes #535

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 7a3d6e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vicb vicb requested a review from james-elicx April 7, 2025 09:56
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 7, 2025 •
edited
Loading

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@536

commit: 7a3d6e1

james-elicx
james-elicx approved these changes Apr 7, 2025
View reviewed changes
Copy link
Collaborator

@james-elicx james-elicx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@vicb vicb requested a review from james-elicx April 7, 2025 12:38
@vicb
Copy link
Contributor Author

vicb commented Apr 7, 2025 •
edited
Loading

Added a commit to hide the (expected) warnings for local mode and add a progress bar


# BEFORE

▲ [WARNING] By default, `wrangler r2` commands access a local simulator of your R2 bucket, the same as that used by `wrangler dev`. To access your remote R2 bucket, re-run the command with the --remote flag


▲ [WARNING] By default, `wrangler r2` commands access a local simulator of your R2 bucket, the same as that used by `wrangler dev`. To access your remote R2 bucket, re-run the command with the --remote flag


▲ [WARNING] By default, `wrangler r2` commands access a local simulator of your R2 bucket, the same as that used by `wrangler dev`. To access your remote R2 bucket, re-run the command with the --remote flag

... as many time as there are cache assets

# AFTER

Populating R2 incremental cache...
100%|█████████████████████████████████████████████| 50/50 [00:33:<00:00:, 1.51it/s]
Successfully populated cache with 50 assets

@vicb vicb merged commit 8abea36 into main Apr 7, 2025
7 checks passed
@vicb vicb deleted the vicb/r2 branch April 7, 2025 12:43
@workers-frameworks workers-frameworks mentioned this pull request Apr 7, 2025
Closed
@vicb vicb mentioned this pull request Apr 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@james-elicx james-elicx james-elicx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] R2 cache population
3 participants
@vicb @petebacondarwin @james-elicx