Skip to content

feat: populate kv incremental cache #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Apr 8, 2025
Merged

feat: populate kv incremental cache #546

merged 18 commits into from
Apr 8, 2025

Conversation

james-elicx
Copy link
Collaborator

@james-elicx james-elicx commented Apr 7, 2025 •
edited
Loading

This PR does the following:

  • Replaces KV cache with a simplified version that only deals with KV.
  • Aligns implementation with the one in r2 inc cache, using debug/error utils from opennext.
  • Populates KV binding with assets.

Should already be covered by existing E2Es.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 852c73a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 7, 2025 •
edited
Loading

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@546

commit: 852c73a

@james-elicx james-elicx linked an issue Apr 7, 2025 that may be closed by this pull request
Auto-population for KV #538
Closed
@james-elicx james-elicx marked this pull request as ready for review April 7, 2025 20:58
@james-elicx james-elicx requested review from vicb and conico974 April 7, 2025 20:58
@james-elicx james-elicx requested a review from vicb April 8, 2025 07:31
@vicb vicb changed the title feat: auto-populate kv incremental cache feat: populate kv incremental cache Apr 8, 2025
vicb
vicb approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the updates, looks great!

@james-elicx james-elicx merged commit 9adc3a3 into main Apr 8, 2025
7 checks passed
@james-elicx james-elicx deleted the james/kv-populate branch April 8, 2025 08:46
@workers-frameworks workers-frameworks mentioned this pull request Apr 8, 2025
Closed
@vicb vicb mentioned this pull request Apr 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicb vicb vicb approved these changes

@conico974 conico974 Awaiting requested review from conico974

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-population for KV
3 participants
@james-elicx @vicb @conico974