-
Notifications
You must be signed in to change notification settings - Fork 45
feat: static assets incremental cache #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 836d162 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
examples/overrides/static-assets-incremental-cache/open-next.config.ts
Outdated
Show resolved
Hide resolved
packages/cloudflare/src/api/overrides/incremental-cache/static-assets-incremental-cache.ts
Outdated
Show resolved
Hide resolved
packages/cloudflare/src/api/overrides/incremental-cache/static-assets-incremental-cache.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the 2 cache PRs
Added minor comments!
packages/cloudflare/src/api/overrides/incremental-cache/static-assets-incremental-cache.ts
Outdated
Show resolved
Hide resolved
packages/cloudflare/src/api/overrides/incremental-cache/static-assets-incremental-cache.ts
Show resolved
Hide resolved
packages/cloudflare/src/api/overrides/incremental-cache/static-assets-incremental-cache.ts
Outdated
Show resolved
Hide resolved
packages/cloudflare/src/api/overrides/incremental-cache/static-assets-incremental-cache.ts
Outdated
Show resolved
Hide resolved
9578228
to
a2410f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, looks like you've added the examples/overrides/static-assets-incremental-cache/.next
folder
Thanks, I have no idea how they got checked in considering they're gitignored! |
packages/cloudflare/src/api/overrides/incremental-cache/static-assets-incremental-cache.ts
Outdated
Show resolved
Hide resolved
…-assets-incremental-cache.ts
examples/overrides/static-assets-incremental-cache/wrangler.jsonc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Victor Berchet <victor@suumit.com>
This PR does the following:
This is intended to be used by people who ONLY want to serve prerendered assets from build-time, with no revalidation capabilities. Basically it's for SSG apps.