Skip to content

feat: static assets incremental cache #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 8, 2025
Merged

Conversation

james-elicx
Copy link
Collaborator

@james-elicx james-elicx commented Apr 7, 2025

This PR does the following:

  • Adds a static assets-based incremental cache.
  • Copies cache files to assets dir during population.

This is intended to be used by people who ONLY want to serve prerendered assets from build-time, with no revalidation capabilities. Basically it's for SSG apps.

Copy link

changeset-bot bot commented Apr 7, 2025

🦋 Changeset detected

Latest commit: 836d162

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Apr 7, 2025

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@547

commit: 836d162

@james-elicx james-elicx marked this pull request as ready for review April 7, 2025 20:58
@james-elicx james-elicx requested review from vicb and conico974 April 7, 2025 20:58
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the 2 cache PRs

Added minor comments!

@james-elicx james-elicx force-pushed the james/static-assets-cache branch from 9578228 to a2410f4 Compare April 8, 2025 08:53
Copy link
Collaborator

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, looks like you've added the examples/overrides/static-assets-incremental-cache/.next folder

@james-elicx
Copy link
Collaborator Author

Oops, looks like you've added the examples/overrides/static-assets-incremental-cache/.next folder

Thanks, I have no idea how they got checked in considering they're gitignored!

@james-elicx james-elicx requested review from vicb and conico974 April 8, 2025 09:41
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Co-authored-by: Victor Berchet <victor@suumit.com>
@james-elicx james-elicx merged commit 25ade6f into main Apr 8, 2025
7 checks passed
@james-elicx james-elicx deleted the james/static-assets-cache branch April 8, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants