Skip to content

Add support for basePath #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 14, 2025
Merged

Add support for basePath #574

merged 5 commits into from
Apr 14, 2025

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Apr 14, 2025

fixes #416

The aws version bump fixes #567

Copy link

pkg-pr-new bot commented Apr 14, 2025

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@574

commit: 5223ac6

@vicb vicb requested review from conico974 and james-elicx and removed request for conico974 April 14, 2025 09:16
Copy link
Collaborator

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question, but other than that LGTM

Copy link

changeset-bot bot commented Apr 14, 2025

🦋 Changeset detected

Latest commit: 5223ac6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vicb
Copy link
Contributor Author

vicb commented Apr 14, 2025

@conico974 PTAL, I have bumped aws to 3.5.7 and sync'd createServerBundle

@@ -190,6 +193,9 @@ async function generateBundle(
patchFetchCacheSetMissingWaitUntil,
patchFetchCacheForISR,
patchUnstableCacheForISR,
patchNextServer,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patchNextServer and patchEnvVars probably means that we can get rid of the NextMinimal patch in here. Likely in a different PR though

@vicb vicb merged commit d310919 into main Apr 14, 2025
7 checks passed
@vicb vicb deleted the basePath-test branch April 14, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Normal request somehow getting "purpose = prefetch" header Add support for Next basePath
2 participants