-
Notifications
You must be signed in to change notification settings - Fork 45
Add support for basePath #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small question, but other than that LGTM
🦋 Changeset detectedLatest commit: 5223ac6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@conico974 PTAL, I have bumped aws to 3.5.7 and sync'd |
@@ -190,6 +193,9 @@ async function generateBundle( | |||
patchFetchCacheSetMissingWaitUntil, | |||
patchFetchCacheForISR, | |||
patchUnstableCacheForISR, | |||
patchNextServer, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
patchNextServer
and patchEnvVars
probably means that we can get rid of the NextMinimal patch in here. Likely in a different PR though
fixes #416
The aws version bump fixes #567