Skip to content

fix a few windows path issues #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix a few windows path issues #599

wants to merge 2 commits into from

Conversation

james-elicx
Copy link
Collaborator

@james-elicx james-elicx commented Apr 22, 2025 •
edited
Loading

Changes:

  • Caches playwright browsers.
  • Fixes several path normalisation issues.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 22, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 3227d36

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 22, 2025 •
edited
Loading

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@599

commit: 3227d36

@james-elicx james-elicx force-pushed the james/windows branch 21 times, most recently from 4ea8600 to a8b5cbe Compare April 27, 2025 19:12
@james-elicx james-elicx marked this pull request as ready for review April 27, 2025 19:43
@vicb
Copy link
Contributor

vicb commented Apr 30, 2025

I have squashed the commits and rebased on main

@james-elicx james-elicx force-pushed the james/windows branch 3 times, most recently from 00c63f7 to 3aa07ee Compare April 30, 2025 18:38
@james-elicx james-elicx changed the title run e2es on windows fix a few windows path issues Apr 30, 2025
@james-elicx james-elicx requested a review from vicb April 30, 2025 19:18
@vicb
Copy link
Contributor

vicb commented Apr 30, 2025

I was thinking about that earlier today, we have 3 choices:

  • drop windows specific code
  • merge the PR now knowing that we won't invest further in windows w/o WSL
  • keep the PR opened if someone wants to take over

Let's discuss during the next weekly?

@james-elicx
Copy link
Collaborator Author

I don't think it makes sense to drop Windows-specific code - if someone wants to come along and fix it in the future then there will still be a decent starting point instead of starting from scratch.

It's just that we won't invest any time going forwards in ensuring new (or old) code supports Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicb vicb Awaiting requested review from vicb

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@james-elicx @vicb