Skip to content

Fix pages router context #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 28, 2025
Merged

Fix pages router context #607

merged 3 commits into from
Apr 28, 2025

Conversation

conico974
Copy link
Collaborator

Fix the shared context used in page router for versions of Next prior to 15.3
Fix #571

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 28, 2025 •
edited
Loading

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@607

commit: 2b7e342

vicb
vicb approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM with a few minor comments

@vicb
Copy link
Contributor

vicb commented Apr 28, 2025

Do you think it's worth adding and e2e test on the aws repo (and sync it here) - I'm not sure if the e2e there runs for i.e. latest 14?

@conico974
Copy link
Collaborator Author

Do you think it's worth adding and e2e test on the aws repo (and sync it here) - I'm not sure if the e2e there runs for i.e. latest 14?

We could add e2e test in aws as well, but we need the one i've used here because in aws we only test against the latest released version (and here we use 15.3.0, which don't have the issue)
I'll create an issue in aws to remind us to do that.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 28, 2025

🦋 Changeset detected

Latest commit: 2b7e342

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@conico974 conico974 merged commit 15f1160 into opennextjs:main Apr 28, 2025
7 checks passed
@workers-frameworks workers-frameworks mentioned this pull request Apr 28, 2025
Closed
@conico974 conico974 mentioned this pull request Apr 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicb vicb vicb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Page router next/head component not working for SSR pages
2 participants
@conico974 @vicb