Skip to content

Add the experimental e2e app #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 30, 2025
Merged

Add the experimental e2e app #614

merged 4 commits into from
Apr 30, 2025

Conversation

conico974
Copy link
Collaborator

@conico974 conico974 commented Apr 29, 2025 •
edited
Loading

The node middleware has been disabled for now, it breaks because of a dynamic require.
Not sure if it makes sense to fix it (at least not in this PR)
Require #613 to be merged first

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 29, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b51a9f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 29, 2025 •
edited
Loading

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@614

commit: b51a9f4

@conico974 conico974 force-pushed the test/experimental-e2e branch from f2ca7ef to 89a6ce8 Compare April 29, 2025 16:45
@vicb
Copy link
Contributor

vicb commented Apr 29, 2025

Not sure if it makes sense to fix it (at least not in this PR)

+1 to postpone that. Could you please create a tracking issue though.

vicb
vicb approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vicb vicb mentioned this pull request Apr 30, 2025
Open
Base automatically changed from chores/sync-aws to main April 30, 2025 12:39
@conico974 conico974 force-pushed the test/experimental-e2e branch from 03a3b96 to b51a9f4 Compare April 30, 2025 12:47
@conico974 conico974 merged commit 2d287ee into main Apr 30, 2025
7 checks passed
@conico974 conico974 deleted the test/experimental-e2e branch April 30, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicb vicb vicb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conico974 @vicb